Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer): separate test utils from shared benchmark and test utils #1613

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ethanoroshiba
Copy link
Contributor

Summary

Separated utils only used by tests from utils used by both benchmarks and tests.

Background

This is to get rid of many strings of nested expects and allows mentioned in #1585

Changes

  • Separated astria-sequencer::test_utils.rs into test_utils.rs and benchmark_and_test_utils.rs.
  • Separated astria-sequencer::app::test_utils.rs into app::test_utils.rs and app::benchmark_and_test_utils.rs.
  • Fixed all the imports which broke as a result.

Testing

All tests working

Related Issues

closes #1585

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Oct 2, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review October 2, 2024 20:28
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner October 2, 2024 20:28
@ethanoroshiba ethanoroshiba added this pull request to the merge queue Oct 29, 2024
@ethanoroshiba ethanoroshiba removed this pull request from the merge queue due to a manual request Oct 29, 2024
@ethanoroshiba ethanoroshiba added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d9913bb Oct 29, 2024
46 checks passed
@ethanoroshiba ethanoroshiba deleted the ENG-877/separate_benchmark_utils branch October 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: separate sequencer testing only utils and utils shared with benchmark feature
2 participants