Remove gossipnet from relayer #366
Conversation
emhane
requested review from
joroshiba,
noot and
SuperFluffy
as code owners
github-actions
bot
added
the
sequencer-relayer
|
I fixed the issue testing the batched celestia blobs. You are right that it has to do with how time is handled in tokio tests: it auto-advances to the next tick, but that happens faster than the mock response + jsonrpc + deserialization, causing all sorts of issues. |
|
@emhane If you give permission I will push my patches fixing the blackbox tests to this branch so that CI passes (Monday or Tuesday). |
if you advance time by the tick interval, naturally this happens. not quite sure how you mean the issue is how tokio handles time in tests? the time is controlled manually in these tests. if you push the patch to a branch I can check it out. will add anything from here if it's not outdated after your changes #347 . |
There was a problem hiding this comment.
The config must be changed to reflect that writing to celestia is now the only functionality of sequencer-relayer.
Please fix the failing tests before merge. They are fixed in #384
## Summary Replace all implicit eyre errors by context specific typed errors ## Background Same reasoning as for #375 as part of the work for #332: `sequencer-types` has to be made a dependency of `sequencer-client`, which only uses typed errors. Therefore `sequencer-types` must have typed errors (because otherwise `sequencer-client` would be "infected" by eyre, which would require changing all of sequencer-client to also use eyre. ## Changes - Introduced one error variant per distinct eyre error. ## Testing N/A. Nothing changed on the code level. Testing that the errors are actually triggered could be done in a follow-up PR, but big parts of the code will be replaced by the work in #355 and follow-up PRs to it, moving the types exchanged over RPCs to the astria-proto crate. ## Breaking Changelist - No observable breaking changes in the astria services. Breaking changes in the library crates because their public API changed (errors), but we are not considering them right now ## Related Issues #12 #86 #366 #332
I needed to investigate why the tests were failing to merge this PR, which is the brunt of #384, and because you noted this:
|
Summary
remove gossipnet from relayer
Background
relayer has in the past submitted blocks to gossipnet for conductor to receive them earlier than celestia. conductor will receive blocks via RPC instead of p2p from one trusted connection to a sequencer node for the near future.
Changes
Testing
removing mock conductor from relayer integration tests, this should not alter the way celestia interacts with tests
Breaking Changelist
slow_celestia_leads_to_bundled_blobsstops working though removing code that submits a block from gossip net doesn't effect the way a block is submitted to celestia. I am positive it has to do with the test framework, specifically how it interleaves time, which is out of scope of this pr to fix.Related Issues
#332, #325
closes #333