Feat: transfer functions for thick discs #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since part of the disc may be obscured, we instead root find a radius on a datum plane at the height of the disc. This is **not a perfect** solution, since it technically only works for well-defined cross section functions. Furthermore, obscuration must then be later recalculated. This does however allow the minima and maxima of the redshift to be determined for a given ring, and therefore for transfer functions to later be calculated for thick discs.
Instead of having to pass around a bunch of arrays, this commit changes the transfer function calculations to use a utility accumulator struct with a handful of methods. Also simplifies the API and paves the way to obscured transfer functions nicely. Added a utils file to `src/transferfunctions` to keep verbose utility methods in.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 68.41% 68.64% +0.22%
==========================================
Files 56 57 +1
Lines 2454 2497 +43
==========================================
+ Hits 1679 1714 +35
- Misses 775 783 +8
|
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
…ansfer-functions Feat: transfer functions for thick discs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer functions can now be obscured on the disc: