Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos in getting started + track getting started code in test suite #183

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

fjebaker
Copy link
Member

@fjebaker fjebaker commented Mar 6, 2024

The code in the getting started part of the tutorial was not being extracted with the docs code extractor for local tests. It therefore has gone quite significantly stale.

All of the figures reproduce except the final one, where the iron line peak has now suddenly become much more pronounced for our fictitious disc. I will open a new issue to track / investigate what happened there, but I believe that is related to some bug fixes for thick discs from a while ago?

Closes #182

@fjebaker fjebaker added the documentation Improvements or additions to documentation label Mar 6, 2024
@fjebaker fjebaker merged commit 80ab5a9 into main Mar 6, 2024
@fjebaker fjebaker deleted the fergus/getting-started-fixes branch March 6, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fov keyword in rendergeodesics
1 participant