L2 reg problem #253
Merged
L2 reg problem #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #253 +/- ##
===============================================
- Coverage 94.91% 94.58% -0.34%
===============================================
Files 66 66
Lines 3619 3619
===============================================
- Hits 3435 3423 -12
- Misses 184 196 +12
Continue to review full report at Codecov.
|
CosmoMatt
reviewed
Oct 24, 2019
There was a problem hiding this comment.
@Luke-Pratley if you're happy this works then I don't see any obvious issues. Have you got an example of how someone would call this in practise?
CosmoMatt
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding forward backward and primal dual solvers for the unconstrained and constrained l2 problems.
Should really add primal dual for unconstrained l1 and l2 problem.
Need to add tests in principle for these solvers (even though the underlying algos have tests that they converge)