This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
Use wcs_to_celestial_frame from Astropy #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s where frames can be registered
astrofrog
force-pushed
the
use-astropy-function
branch
from
f7253c6
to
393bb4f
Compare
astrofrog
force-pushed
the
use-astropy-function
branch
from
899922d
to
80e40d7
Compare
astrofrog
added a commit
that referenced
this pull request
Aug 20, 2015
Use wcs_to_celestial_frame from Astropy
astrofrog
added a commit
that referenced
this pull request
Nov 28, 2016
Use wcs_to_celestial_frame from Astropy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Cadair - this fixes your issue. The problem was we had a clone of wcs_to_celestial_frame in
wcsaxes.wcs_utiilsso it wasn't seeing that you registered the frame. I think it makes sense to now bump the requirement to Astropy >= 1.0 and use the Astropy function.