This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
Make get_coordinate_system extensible #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work for me. |
|
Great! Needs tests and docs (will do when traveling) |
|
although it should be in astropy :p |
|
Of course - this is just a stop-gap measure :) |
astrofrog
changed the title
|
@Cadair - notice the small change to the function names |
| """ | ||
| from copy import deepcopy | ||
| for identifier in deepcopy(FRAME_IDENTIFIERS): | ||
| FRAME_IDENTIFIERS.remove(identifier) |
There was a problem hiding this comment.
I assume you have to do this like this because it is a global variable? and doing FRAME_IDENTIFIERS = [] wont work?
There was a problem hiding this comment.
what if you put a global FRAME_IDENTIFIERS at the top of the function?
There was a problem hiding this comment.
That would be too easy! ;) (fixed)
| assert get_coordinate_frame(wcs) is Galactic | ||
|
|
||
| wcs = WCS(naxis=2) | ||
| wcs.wcs.ctype = ['SOLARX', 'SOLARY'] |
There was a problem hiding this comment.
I like that this is your break example :p
astrofrog
added a commit
that referenced
this pull request
Jul 2, 2014
Make get_coordinate_system extensible
astrofrog
added a commit
that referenced
this pull request
Nov 28, 2016
Make get_coordinate_system extensible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.