Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removes stray todo comments from base_bootstrap #101

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Mar 5, 2024

This PR removes some stray todo comments from base_bootstrap

@fkiraly fkiraly added the enhancement New feature or request label Mar 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (5d53806) to head (00a28e8).
Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   84.77%   88.21%   +3.44%     
==========================================
  Files          17       31      +14     
  Lines        2607     2767     +160     
==========================================
+ Hits         2210     2441     +231     
+ Misses        397      326      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 50662d7 into astrogilda:main Mar 11, 2024
36 checks passed
astrogilda pushed a commit that referenced this pull request Mar 16, 2024
This PR removes some stray todo comments from `base_bootstrap`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants