Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] fix: PR CI trigger condition #11

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Nov 23, 2023

Fixes an unreported bug - it would seem that CI is not triggered on PR by GHA.

This minimal changes that CI works as intended, on PR.

@fkiraly fkiraly added the enhancement New feature or request label Nov 23, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 23, 2023

... why do we lint commit messages at a stage where they have already been committed?

I think a better solution is to allow only sqash commits (default PR title and preamble)

@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 23, 2023

... & you don't like windows users? 😄

@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 23, 2023

... the tests take kind of long, given that there are only a few estimators in here ...

I would recommend profiling and see how long which tests take.

@fkiraly fkiraly mentioned this pull request Nov 23, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Dec 1, 2023

FYI, I added a fail-fast: false flag to the matrix CI, so all elements run to the end even if one fails. Why: will run simultaneously anyway, so expected to terminate around the same time, shutting most of them down close to the end will waste the information on whether the failure is also on other python versions or OS.

@astrogilda astrogilda changed the title [MNT] fix PR CI trigger condition [MNT] fix: PR CI trigger condition Jan 5, 2024
@astrogilda astrogilda merged commit cab8626 into astrogilda:main Jan 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants