Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: base pyproject and CI on pip (from poetry), windows and 3.12 tests #57

Merged
merged 43 commits into from
Feb 4, 2024
Merged

maint: base pyproject and CI on pip (from poetry), windows and 3.12 tests #57

merged 43 commits into from
Feb 4, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Feb 4, 2024 •
edited
Loading

This PR moves pyproject and CI from being based on poetry to being based on pip.

This enables:

  • commands like pip install tsbootstrap[all_extras], where previously the user would have been forced to use poetry
  • the same CI element testing 3.10-3.12 and all three OS windows (new), macOS, unix (relying on the above command)

Depends on #54.

@fkiraly fkiraly added the dependencies Pull requests that update a dependency file label Feb 4, 2024
@fkiraly fkiraly mentioned this pull request Feb 4, 2024
Closed
@fkiraly fkiraly mentioned this pull request Feb 4, 2024
Merged
@fkiraly fkiraly changed the title maint: base pyproject and CI on pip (from poetry) maint: base pyproject and CI on pip (from poetry), windows tests Feb 4, 2024
@fkiraly fkiraly changed the title maint: base pyproject and CI on pip (from poetry), windows tests maint: base pyproject and CI on pip (from poetry), windows and 3.12 tests Feb 4, 2024
@fkiraly fkiraly merged commit e55e81b into astrogilda:main Feb 4, 2024
21 checks passed
@fkiraly fkiraly mentioned this pull request Feb 4, 2024
Closed
@fkiraly fkiraly linked an issue Feb 4, 2024 that may be closed by this pull request
dependencies consolidation #49
Closed
@fkiraly fkiraly mentioned this pull request Feb 4, 2024
Closed
fkiraly added a commit that referenced this pull request Feb 5, 2024
@fkiraly
maint: python 3.8 and 3.9 support - based on pip pyproject.toml (#60
faa29e7 
)

Extends supported version range to python 3.8 and 3.9.

Based on #57 which uses a `pip` based `pyproject.toml`.
#57 should be merged first.

Main changes to enable python 3.8 and 3.9 compatibility:

* removal of type hinting introduced post 3.8
* isolation of type definitions conditional on python 3.8 and 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dependencies consolidation
1 participant
@fkiraly