Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusion between cartesian and spherical coordinates for ShellEnvelope and BoxEnvelope #44

Merged
merged 10 commits into from
Jun 14, 2018

Conversation

JulienPeloton
Copy link
Member

This PR is linked to the discussion in #42.
Main changes:

  • Specify the coordinate system when instantiating a ShellEnvelope with (x, y, z)
  • BoxEnvelope accepts only Point3D with cartesian coordinates (instance + intersection).
  • Rename sphericalToEuclidean to sphericalToCartesian, euclideanToSpherical to cartesianToSpherical in Utils.scala.

A few other fix and change made + unit tests added.

@JulienPeloton JulienPeloton self-assigned this Jun 14, 2018
@JulienPeloton JulienPeloton merged commit 7efc626 into master Jun 14, 2018
@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #44 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #44     +/-   ##
========================================
+ Coverage   98.99%   99.3%   +0.3%     
========================================
  Files          18      18             
  Lines         697     716     +19     
  Branches      166     192     +26     
========================================
+ Hits          690     711     +21     
+ Misses          7       5      -2
Impacted Files Coverage Δ
src/main/scala/com/spark3d/utils/Utils.scala 100% <ø> (ø) ⬆️
...la/com/spark3d/geometryObjects/ShellEnvelope.scala 97.53% <100%> (+0.09%) ⬆️
...in/scala/com/spark3d/geometryObjects/Point3D.scala 100% <100%> (ø) ⬆️
...cala/com/spark3d/geometryObjects/BoxEnvelope.scala 100% <100%> (ø) ⬆️
...ain/scala/com/spark3d/spatial3DRDD/SphereRDD.scala 100% <100%> (+5%) ⬆️
...com/spark3d/spatialOperator/CenterCrossMatch.scala 100% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3cfa3...b96b78c. Read the comment docs.

@JulienPeloton JulienPeloton deleted the fixShellEnvelopeConstr branch June 18, 2018 18:30
@JulienPeloton JulienPeloton added bug Something isn't working JTS replacement 3D objects code cleaning labels Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code cleaning JTS replacement 3D objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants