Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deployment create #1483

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix deployment create #1483

merged 1 commit into from
Jan 9, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jan 9, 2024

Description

Describe the purpose of this pull request.

Fix deployment create

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (840b02e) 86.69% compared to head (91af000) 86.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files         115      115           
  Lines       14182    14182           
=======================================
  Hits        12295    12295           
  Misses       1128     1128           
  Partials      759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani marked this pull request as ready for review January 9, 2024 05:59
@sunkickr sunkickr merged commit 59518f0 into main Jan 9, 2024
5 checks passed
@sunkickr sunkickr deleted the fix-deployment-create branch January 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants