accept the correct input for executor #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
|
can we add test cases for all types that are accepted. Also, do we need to update the flag description to indicate what is supported? Can you expand more on your PR description so its clear what is changing for anyone else who do not have proper context |
vandyliu
reviewed
Feb 1, 2024
cloud/deployment/deployment.go
Outdated
| @@ -344,9 +344,10 @@ func Create(name, workspaceID, description, clusterID, runtimeVersion, dagDeploy | |||
| requestedCloudProvider = astroplatformcore.CreateStandardDeploymentRequestCloudProviderAZURE | |||
| } | |||
| var requestedExecutor astroplatformcore.CreateStandardDeploymentRequestExecutor | |||
| if executor == CeleryExecutor { | |||
| if strings.ToUpper(executor) == strings.ToUpper(CeleryExecutor) || strings.ToUpper(executor) == strings.ToUpper(CELERY) { | |||
There was a problem hiding this comment.
can we add some unit tests for all these cases
vandyliu
approved these changes
Feb 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
- Coverage 85.90% 85.84% -0.07%
==========================================
Files 112 112
Lines 14847 14862 +15
==========================================
+ Hits 12755 12758 +3
- Misses 1254 1266 +12
Partials 838 838 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it so deployment create/update accept the correct executor input
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft