Do not throw the error for astro deploy if dag-deploy itself is disabled #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rujhan-arora-astronomer
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
kushalmalani
reviewed
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
=======================================
Coverage 86.08% 86.09%
=======================================
Files 112 112
Lines 14900 14903 +3
=======================================
+ Hits 12827 12830 +3
Misses 1253 1253
Partials 820 820 ☔ View full report in Codecov by Sentry. |
kushalmalani
approved these changes
Feb 8, 2024
kushalmalani
pushed a commit
that referenced
this pull request
Feb 9, 2024
…led (#1538) * Do not throw the error for astro deploy if dag-deploy itself is disabled * Do not throw the error for astro deploy if dag-deploy itself is disabled * Do not throw the error for astro deploy if dag-deploy itself is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not throw the error for astro deploy if dag-deploy itself is disabled
🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/6151
🧪 Functional Testing
Tested on Local
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft