Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pool list/create #1548

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix pool list/create #1548

merged 1 commit into from
Feb 13, 2024

Conversation

sunkickr
Copy link
Contributor

Description

fix panic error for pool list/create on standard deployments

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@sunkickr sunkickr merged commit bf54bf4 into main Feb 13, 2024
3 checks passed
@sunkickr sunkickr deleted the fix-pool-list/create branch February 13, 2024 16:34
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4ed1438) 86.06% compared to head (268f730) 86.06%.
Report is 2 commits behind head on main.

Files Patch % Lines
cloud/deployment/inspect/inspect.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         112      112           
  Lines       14916    14917    +1     
=======================================
+ Hits        12837    12838    +1     
  Misses       1258     1258           
  Partials      821      821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kushalmalani pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants