-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include active hibernation override info in deployment metadata #1597
Include active hibernation override info in deployment metadata #1597
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1597 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 114 114
Lines 15935 15940 +5
=======================================
+ Hits 13792 13797 +5
Misses 1288 1288
Partials 855 855 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@feluelle Is this good to merge? |
I will manually test this to be sure. |
I have found an issue on the core platform API side which holds me back from e2e testing it. The |
Works as expected. I have added the tests to the PR description. @kushalmalani feel free to merge. |
Description
🎟 Issue(s)
closes: #1575
🧪 Functional Testing
📸 Screenshots
For a deployment with override defined:
For a deployment without override defined:
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft