Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating deploy commands to use v1beta deploy endpoints #1638

Merged
merged 4 commits into from
May 7, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented May 2, 2024

Description

Describe the purpose of this pull request.

Updating deploy commands to use v1beta deploy endpoints

🎟 Issue(s)

Related astronomer/astro#19893, #1181

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Dag Only Deploy
Screenshot 2024-05-01 at 23 54 34

Image and Dag Deploy (astro deploy)
Screenshot 2024-05-01 at 23 54 46
Screenshot 2024-05-01 at 23 55 01

Cannot use --image and --dag flag together
Screenshot 2024-05-02 at 00 01 03

Image only deploy
Screenshot 2024-05-02 at 00 05 38
Screenshot 2024-05-02 at 00 05 59

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (3a21a22) to head (39b9a31).

Files Patch % Lines
cloud/deploy/deploy.go 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   86.74%   86.77%   +0.03%     
==========================================
  Files         114      114              
  Lines       16693    16690       -3     
==========================================
+ Hits        14480    14483       +3     
+ Misses       1323     1320       -3     
+ Partials      890      887       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit 0a3d52a into main May 7, 2024
4 of 5 checks passed
@kushalmalani kushalmalani deleted the deploys-v1beta1 branch May 7, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants