Error should be returned if BYORegistryEnabled is true but BYORegistryDomain is empty #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istry.host is not present
rujhan-arora-astronomer
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
…istry.host is not present
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 114 114
Lines 16691 16693 +2
=======================================
+ Hits 14478 14480 +2
Misses 1323 1323
Partials 890 890 ☔ View full report in Codecov by Sentry. |
pgvishnuram
approved these changes
May 2, 2024
pgvishnuram
reviewed
May 2, 2024
| @@ -41,6 +41,7 @@ var ( | |||
| ErrDagOnlyDeployDisabledInConfig = errors.New("to perform this operation, set both deployments.dagOnlyDeployment and deployments.configureDagDeployment to true in your Astronomer cluster") | |||
| ErrDagOnlyDeployNotEnabledForDeployment = errors.New("to perform this operation, first set the Deployment type to 'dag_deploy' via the UI or the API or the CLI") | |||
| ErrEmptyDagFolderUserCancelledOperation = errors.New("no DAGs found in the dags folder. User canceled the operation") | |||
| ErrBYORegistryDomainNotSet = errors.New("Custom registry host is not set in config. It can be set at astronomer.houston.config.deployments.registry.protectedCustomRegistry.updateRegistry.host") //nolint | |||
There was a problem hiding this comment.
@rishkarajgi is this wording is okay
kushalmalani
reviewed
May 2, 2024
| @@ -41,6 +41,7 @@ var ( | |||
| ErrDagOnlyDeployDisabledInConfig = errors.New("to perform this operation, set both deployments.dagOnlyDeployment and deployments.configureDagDeployment to true in your Astronomer cluster") | |||
| ErrDagOnlyDeployNotEnabledForDeployment = errors.New("to perform this operation, first set the Deployment type to 'dag_deploy' via the UI or the API or the CLI") | |||
| ErrEmptyDagFolderUserCancelledOperation = errors.New("no DAGs found in the dags folder. User canceled the operation") | |||
| ErrBYORegistryDomainNotSet = errors.New("Custom registry host is not set in config. It can be set at astronomer.houston.config.deployments.registry.protectedCustomRegistry.updateRegistry.host") //nolint | |||
There was a problem hiding this comment.
Why is the linting check removed for this?
There was a problem hiding this comment.
@kushalmalani It says Capital letters are not allowed within a string. So, protectedCustomRegistry was giving an error :P
kushalmalani
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error should be returned if BYORegistryEnabled is true but BYORegistryDomain is empty
🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/6100
🧪 Functional Testing
Tested locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft