LoadFile should return a dataframe if not using XCom backend
#1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `LoadFileOperator` converts dataframe to a File object when returning. However, this should be handled by the Custom XCom backend and not in `LoadFileOperator`. Otherwise, we won't be consistent with dataframe and transform decorators who, too returns dataframes. From Airflow 2.5 and above, this should be handled automatically, for older versions, users should use our Custom XCom backend so that their XCom table isn't fully of GBs of data.
kaxil
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 95.71% // Head: 94.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 95.71% 94.70% -1.02%
==========================================
Files 19 73 +54
Lines 677 3513 +2836
Branches 68 402 +334
==========================================
+ Hits 648 3327 +2679
- Misses 18 114 +96
- Partials 11 72 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
feluelle
approved these changes
Dec 5, 2022
kaxil
added a commit
that referenced
this pull request
Dec 13, 2022
Currently, the `LoadFileOperator` converts dataframe to a File object when returning. However, this should be handled by the Custom XCom backend and not in `LoadFileOperator`. Otherwise, we won't be consistent with dataframe and transform decorators who, too returns dataframes. From Airflow 2.5 and above, this should be handled automatically, for older versions, users should use our Custom XCom backend so that their XCom table isn't fully of GBs of data. part of #1337 ## Does this introduce a breaking change? No, if you are using our XCom backend. Yes, if you are not! but this fixes the behaviour and makes it consistent with other decorators and operators that return dataframes ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary (cherry picked from commit 1283394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
LoadFileOperatorconverts dataframe to a File object when returning. However, this should be handled by the Custom XCom backend and not inLoadFileOperator. Otherwise, we won't be consistent with dataframe and transform decorators who, too returns dataframes.From Airflow 2.5 and above, this should be handled automatically, for older versions, users should use our Custom XCom backend so that their XCom table isn't fully of GBs of data.
part of #1337
Does this introduce a breaking change?
No, if you are using our XCom backend. Yes, if you are not! but this fixes the behaviour and makes it consistent with other decorators and operators that return dataframes
Checklist