Disable Custom serialization for Back-compat #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.79% // Head: 97.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
+ Coverage 93.79% 97.32% +3.52%
==========================================
Files 80 19 -61
Lines 3883 672 -3211
Branches 378 0 -378
==========================================
- Hits 3642 654 -2988
+ Misses 164 18 -146
+ Partials 77 0 -77 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We only need AstroPandasDataframe and other custom serialization and deserialization if Airflow >= 2.5 and Pickling is not enabled and neither Custom XCom backend is used. For others, we should leave it untouched.
kaxil
force-pushed
the
disable-custom-s10n
branch
from
059f1a5
to
06ea423
Compare
kaxil
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
kaxil
added a commit
that referenced
this pull request
Dec 18, 2022
We only need AstroPandasDataframe and other custom serialization and deserialization if Airflow >= 2.5 and Pickling is not enabled and neither Custom XCom backend is used. For others, we should leave it untouched. (cherry picked from commit 5c69b4d)
|
Why do we merge without review/approval? Could we comment that here then at least? It should not become the standard! @kaxil |
|
I should have left the comment, sorry - This was for Cloud IDE team, I cut an 1.3.3b1 version for them after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need AstroPandasDataframe and other custom serialization and deserialization if Airflow >= 2.5 and Pickling is not enabled and neither Custom XCom backend is used.
For others, we should leave it untouched.