Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "s3" conn type for S3Location #1647

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Support "s3" conn type for S3Location #1647

merged 1 commit into from
Jan 20, 2023

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Jan 20, 2023

Amazon S3 conn type was removed in Airflow in favor of AWS in apache/airflow@cf73cb7

In SDK, we should support both. This was identified in Cloud IDE

image

Amazon S3 conn type was removed in Airflow in favor of AWS in apache/airflow@cf73cb7

In SDK, we should support both. This was identified in Cloud IDE
Copy link

@joedborg joedborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 97.71% // Head: 97.71% // No change to project coverage 👍

Coverage data is based on head (106a10e) compared to base (96c1abf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          21       21           
  Lines         831      831           
=======================================
  Hits          812      812           
  Misses         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaxil kaxil merged commit 5cdbed4 into main Jan 20, 2023
@kaxil kaxil deleted the s3-conn-type branch January 20, 2023 21:28
@kaxil
Copy link
Collaborator Author

kaxil commented Jan 20, 2023

uff my bad -- looks like tests were failing, I will check if they were related or unrelated

thankfully all of them were unrelated failrues

kaxil added a commit that referenced this pull request Jan 20, 2023
Amazon S3 conn type was removed in Airflow in favor of AWS in
apache/airflow@cf73cb7

In SDK, we should support both. This was identified in Cloud IDE

![image](https://user-images.githubusercontent.com/8811558/213798026-bc17dbc0-50f2-47b1-b7e1-419578ef2cd5.png)

(cherry picked from commit 5cdbed4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants