-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing copy_options and file_options for snowflake native transfers #1707
Conversation
…ers for azure test
Codecov ReportBase: 97.72% // Head: 97.72% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 21 21
Lines 835 835
=======================================
Hits 816 816
Misses 19 19 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunank200 I'm slightly worried that it examples, for which we control the data, requestor the on error continue flag. Would it be possible for us to review this in a separate ticket/PR? My feeling is tha this should be the exception and not the rule.
I'm happy for the PR to be merged once the checks pass :)
@tatiana Currently we are passing |
Also, CI is failing for unrelated issues for databricks tests which can be done in a separate ticket. The rest of the tests has passed. So merging this PR |
…ers (#1707) # Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> This PR missed the native transfers arguments for snowflake to azure transfers in main <!--Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1708 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add missing copy_options and file_options for snowflake native transfers for azure tests ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary
Description
What is the current behavior?
This PR missed the native transfers arguments for snowflake to azure transfers in main
closes: #1708
What is the new behavior?
Does this introduce a breaking change?
No
Checklist