Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing copy_options and file_options for snowflake native transfers #1707

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

sunank200
Copy link
Contributor

@sunank200 sunank200 commented Feb 3, 2023

Description

What is the current behavior?

This PR missed the native transfers arguments for snowflake to azure transfers in main

closes: #1708

What is the new behavior?

  • Add missing copy_options and file_options for snowflake native transfers for azure tests

Does this introduce a breaking change?

No

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sunank200 sunank200 added this to the 1.5.0 milestone Feb 3, 2023
@sunank200 sunank200 marked this pull request as ready for review February 3, 2023 12:41
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 97.72% // Head: 97.72% // No change to project coverage 👍

Coverage data is based on head (18cd23a) compared to base (5aa43eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1707   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          21       21           
  Lines         835      835           
=======================================
  Hits          816      816           
  Misses         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunank200 I'm slightly worried that it examples, for which we control the data, requestor the on error continue flag. Would it be possible for us to review this in a separate ticket/PR? My feeling is tha this should be the exception and not the rule.

I'm happy for the PR to be merged once the checks pass :)

@sunank200
Copy link
Contributor Author

@sunank200 I'm slightly worried that it examples, for which we control the data, requestor the on error continue flag. Would it be possible for us to review this in a separate ticket/PR? My feeling is tha this should be the exception and not the rule.

I'm happy for the PR to be merged once the checks pass :)

@tatiana Currently we are passing ON_ERROR=CONTINUE as its failing for the header. We can also pass SKIP_HEADER=1

@sunank200
Copy link
Contributor Author

@sunank200 I'm slightly worried that it examples, for which we control the data, requestor the on error continue flag. Would it be possible for us to review this in a separate ticket/PR? My feeling is tha this should be the exception and not the rule.

I'm happy for the PR to be merged once the checks pass :)

Also, CI is failing for unrelated issues for databricks tests which can be done in a separate ticket. The rest of the tests has passed. So merging this PR

@sunank200 sunank200 merged commit 70834e3 into main Feb 3, 2023
@sunank200 sunank200 deleted the snowflake-native-missing-params branch February 3, 2023 12:56
utkarsharma2 pushed a commit that referenced this pull request Feb 8, 2023
…ers (#1707)

# Description
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
This PR missed the native transfers arguments for snowflake to azure
transfers in main

<!--Issues are required for both bug fixes and features.
Reference it using one of the following:

closes: #ISSUE
related: #ISSUE
-->
closes: #1708


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Add missing copy_options and file_options for snowflake native
transfers for azure tests


## Does this introduce a breaking change?
No

### Checklist
- [x] Created tests which fail without the change (if possible)
- [x] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing copy_options for snowflake transfers to azure
2 participants