Check if connection is minio then set use_native_support=False #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.62% // Head: 93.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 92.62% 93.05% +0.42%
==========================================
Files 93 93
Lines 4923 4937 +14
Branches 484 486 +2
==========================================
+ Hits 4560 4594 +34
+ Misses 265 248 -17
+ Partials 98 95 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@sunank200 can you please offer more context in the PR template as to what this PR is doing and why we are doing it? Maybe a bit on how it solves this bug? |
sure @dimberman This PR is still in draft but I have updated the PR description |
sunank200
requested review from
dimberman,
tatiana,
utkarsharma2,
pankajastro,
pankajkoti,
feluelle and
kaxil
as code owners
tatiana
reviewed
Feb 17, 2023
tatiana
reviewed
Feb 17, 2023
tatiana
approved these changes
Feb 21, 2023
utkarsharma2
force-pushed
the
minio-fix
branch
from
0fdb9cb
to
60b3d14
Compare
utkarsharma2
added a commit
that referenced
this pull request
Feb 21, 2023
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When the user passes the s3 url but has minio as the setup, for minio to any database transfers by default it uses the native path and fails as there is no native path. There is no direct way to check if the connection is of type minio. Introducing a parameter `minio` in extras as part of connections would help to recognize the connection type <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1746 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Check if the AWS connection has `minio` in `extra` then set use_native_support=False - Example minio conn: ``` - conn_id: minio_conn conn_type: aws description: null extra: aws_access_key_id: "dummy" aws_secret_access_key: "dummy" endpoint_url: "http://127.0.0.1:9000" minio: True ``` ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary --------- Co-authored-by: utkarsh sharma <utkarsharma2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
When the user passes the s3 url but has minio as the setup, for minio to any database transfers by default it uses the native path and fails as there is no native path. There is no direct way to check if the connection is of type minio. Introducing a parameter
minioin extras as part of connections would help to recognize the connection typecloses: #1746
What is the new behavior?
minioinextrathen set use_native_support=FalseDoes this introduce a breaking change?
No
Checklist