-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the wasb connection #1994
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 72 72
Lines 4262 4262
Branches 530 530
=======================================
Hits 3822 3822
Misses 343 343
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are we no longer getting it? If it's a regression, we need to fix it in airflow |
python-sdk/pyproject.toml
Outdated
@@ -73,7 +73,7 @@ amazon = [ | |||
"smart-open[s3]>=5.2.1", | |||
] | |||
azure = [ | |||
"apache-airflow-providers-microsoft-azure", | |||
"apache-airflow-providers-microsoft-azure<=6.2.2", # TODO: Unpin this when we get self.hook.get_conn().account_name as not none for wasb hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have some ticket for this in upstream lib, I feel that way it is easy to track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just created an upstream bug, will create a bug on our end as well - apache/airflow#33203
@ephraimbuddy Yes, I think so, it's a bug in the latest release 6.2.3. I'm planning to look into it post-releasing SDK. |
If we release this, it won't work with runtime so why release now instead of fixing the issue and making it part of the current providers release? |
@ephraimbuddy There is a customer waiting for pandas 2.0 support which is part of this release. |
But they would access cloud IDE by (indirectly) using Astro runtime right? |
@phanikumv I'm not sure if they use runtime or not. But as @ephraimbuddy suggested a fix in connection, should unlock us from runtime issue as well. I'm trying the fix as we speak. |
@utkarsharma2, we could also try to change how we build the URL in this part of the code: It seems the |
@tatiana I looked into it and even |
In version apache-airflow-providers-microsoft-azure==6.2.3 we are no longer getting the `self.hook.get_conn().account_name` to bypass the issue we can create connection in below fashion: ``` - conn_id: wasb_conn_with_access_key conn_type: wasb login: astrosdk host: astrosdk.blob.core.windows.net description: null extra: shared_access_key: $AZURE_WASB_ACCESS_KEY ```
In version apache-airflow-providers-microsoft-azure==6.2.3 we are no longer getting the
self.hook.get_conn().account_name
to bypass the issue we can create connection in below fashion: