Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MergeOperator #422

Merged
merged 6 commits into from
Jun 2, 2022
Merged

Refactor MergeOperator #422

merged 6 commits into from
Jun 2, 2022

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Jun 2, 2022

This PR refactors the Merge operator to use the new interfaces. This PR intends to keep the same logic as now and just use new interfaces so we can delete all the old files from old interfaces. The scope to whether or not we should have a single function or not is kept for #383

part of #343

@kaxil kaxil force-pushed the merge-new-api branch 4 times, most recently from 2b098b5 to 027d21d Compare June 2, 2022 04:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #422 (f4adc7e) into main (7fa0404) will increase coverage by 0.10%.
The diff coverage is 94.02%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   90.44%   90.55%   +0.10%     
==========================================
  Files          53       49       -4     
  Lines        1801     1778      -23     
  Branches      280      275       -5     
==========================================
- Hits         1629     1610      -19     
+ Misses        133      131       -2     
+ Partials       39       37       -2     
Impacted Files Coverage Δ
src/astro/databases/snowflake.py 92.70% <90.90%> (-4.17%) ⬇️
src/astro/databases/sqlite.py 95.00% <92.30%> (-1.43%) ⬇️
src/astro/databases/postgres.py 98.30% <95.00%> (-1.70%) ⬇️
src/astro/constants.py 94.44% <100.00%> (+0.15%) ⬆️
src/astro/databases/base.py 96.73% <100.00%> (-1.04%) ⬇️
src/astro/databases/google/bigquery.py 95.45% <100.00%> (+1.33%) ⬆️
src/astro/sql/__init__.py 100.00% <100.00%> (ø)
src/astro/sql/operators/merge.py 100.00% <100.00%> (+11.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa0404...f4adc7e. Read the comment docs.

@kaxil kaxil force-pushed the merge-new-api branch 2 times, most recently from bcbb614 to 3ff6ad2 Compare June 2, 2022 10:35
@kaxil kaxil marked this pull request as ready for review June 2, 2022 15:33
@kaxil kaxil merged commit 03f0e99 into main Jun 2, 2022
@kaxil kaxil deleted the merge-new-api branch June 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants