Allow list and tuples as columns names in Append & Merge #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 90.97% 91.04% +0.06%
==========================================
Files 41 41
Lines 1319 1329 +10
Branches 168 172 +4
==========================================
+ Hits 1200 1210 +10
Misses 99 99
Partials 20 20
Continue to review full report at Codecov.
|
tatiana
added
improvement
addresses #439 (comment) Tt feels tedious and probably most of the times the col names would be the same. This commit renames `source_to_target_columns_map` param in Append and Merge operator to `columns` and allows passing either a) list or tuples containing col names b) dict containing source to target mapping. Before: ```python append( source_table=filtered_data, target_table=Table(name="homes_reporting", conn_id=SNOWFLAKE_CONN_ID), source_to_target_columns_map={ "sell": "sell", "list": "list", "variable": "variable", "value": "value", }, ) ``` After: ```python append( source_table=filtered_data, target_table=Table(name="homes_reporting", conn_id=SNOWFLAKE_CONN_ID), columns=["sell", "list", "variable", "value"] ) ```
| task_id: str = "", | ||
| **kwargs: Any, | ||
| ) -> None: | ||
| self.source_table = source_table | ||
| self.target_table = target_table | ||
| self.source_to_target_columns_map = source_to_target_columns_map or {} | ||
|
|
||
| if isinstance(columns, (list, tuple)): |
There was a problem hiding this comment.
Hey @kaxil, nothing major, but can we move lines 36 - 41 to a function and use that function in the append and merge operators just to avoid some code duplication?
There was a problem hiding this comment.
In this case, DAMP (“Descriptive and Meaningful Phrases”) approach is better than DRY (“Don’t Repeat Yourself”) as they are hardly 4-5 lines :)
utkarsharma2
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #439 (comment)
Tt feels tedious and probably most of the times the col names would be the same. This commit renames
source_to_target_columns_mapparam in Append and Merge operator tocolumnsand allows passing either a) list or tuples containing col names b) dict containing source to target mapping.Before:
After:
ToDo: