Use exc_info for exception logging #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro and
pankajkoti
as code owners
kaxil
approved these changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 93.29% 93.28% -0.02%
==========================================
Files 41 41
Lines 1670 1667 -3
Branches 210 210
==========================================
- Hits 1558 1555 -3
Misses 89 89
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pankajastro
approved these changes
Aug 12, 2022
|
@feluelle I need this. can we merge this? |
|
@pankajastro yes. I wanted to wait until all checks are done. |
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Use exc_info for exception logging * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove logging import from bigquery Co-authored-by: feluelle <felix.uellendall@astronomer.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Exceptions are currently being printed in
logging.warningwithoutexc_info.related: #638
What is the new behavior?
Use exc_info for exception logging
Does this introduce a breaking change?
No
Checklist