Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize language in docs files #678

Merged
merged 8 commits into from
Aug 18, 2022
Merged

Standardize language in docs files #678

merged 8 commits into from
Aug 18, 2022

Conversation

kentdanas
Copy link
Collaborator

Description

Update documentation to use standardized language in line with Astronomer's style guide.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #678 (5f0e6eb) into main (bd3f51c) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f0e6eb differs from pull request most recent head 3b5b045. Consider uploading reports for the commit 3b5b045 to get more accurate results

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          42       42           
  Lines        1701     1701           
  Branches      216      216           
=======================================
  Hits         1573     1573           
  Misses        102      102           
  Partials       26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. It looks so much better. I have a few suggestions though (see below). Let me know what you think.

docs/astro/sql/operators/dataframe.rst Outdated Show resolved Hide resolved
docs/astro/sql/operators/load_file.rst Outdated Show resolved Hide resolved
docs/astro/sql/operators/transform.rst Outdated Show resolved Hide resolved
docs/astro/sql/operators/transform.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes. It looks much better now. I have added few suggestions.

Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
Copy link
Collaborator

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kentdanas , this looks great

Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
@kaxil kaxil added this to the 1.0.0 milestone Aug 18, 2022
@kaxil kaxil merged commit d96d9c4 into main Aug 18, 2022
@kaxil kaxil deleted the docs_edits branch August 18, 2022 13:34
kaxil pushed a commit that referenced this pull request Aug 18, 2022
Update documentation to use standardized language in line with Astronomer's style guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants