Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration details from settings.py #861

Merged
merged 14 commits into from
Sep 16, 2022
Merged

Conversation

sunank200
Copy link
Contributor

Description

What is the current behavior?

Add missing configurations

closes: #860

What is the new behavior?

Does this introduce a breaking change?

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 93.27% // Head: 93.22% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (137d63c) compared to base (2692d1c).
Patch has no changes to coverable lines.

❗ Current head 137d63c differs from pull request most recent head 2e5b43f. Consider uploading reports for the commit 2e5b43f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   93.27%   93.22%   -0.05%     
==========================================
  Files          47       47              
  Lines        2051     2052       +1     
  Branches      257      260       +3     
==========================================
  Hits         1913     1913              
  Misses        107      107              
- Partials       31       32       +1     
Impacted Files Coverage Δ
python-sdk/src/astro/databases/google/bigquery.py 93.82% <0.00%> (-0.60%) ⬇️
python-sdk/src/astro/settings.py 100.00% <0.00%> (ø)
python-sdk/src/astro/airflow/datasets.py 94.73% <0.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sunank200 sunank200 added this to the 1.1.0 milestone Sep 16, 2022
@utkarsharma2 utkarsharma2 removed this from the 1.1.0 milestone Sep 16, 2022
sunank200 and others added 13 commits September 16, 2022 15:56
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@sunank200 sunank200 merged commit cb9917f into main Sep 16, 2022
@sunank200 sunank200 deleted the configuration-docs branch September 16, 2022 10:13
@sunank200 sunank200 added this to the 1.1.0 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurations from settings.py to configurations.html
4 participants