Use DbApiHook's split_sql_string instead of snowflake utility in amazon provider #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on provider Currently, the redshift_data hook in the Amazon provider relies has a dependency on snowflake for it's utility to split sql string. The PR removes this need by instead using the DbApiHook's split_sql_string which reliably parses the sql strings for us. closes: #1259
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200 and
utkarsharma2
as code owners
|
Verified that our Redshift SQL example DAG which passes sql strings in various formats runs well. 
|
pankajastro
approved these changes
Jul 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 98.57% 98.57% -0.01%
==========================================
Files 90 90
Lines 5396 5393 -3
==========================================
- Hits 5319 5316 -3
Misses 77 77
☔ View full report in Codecov by Sentry. |
Lee-W
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the redshift_data hook in the Amazon provider has
a dependency on snowflake for it's utility to split sql strings.
The PR removes this need by instead using the DbApiHook's
split_sql_stringwhich reliably parses the sql strings for us.closes: #1259