-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle soft fail #1276
Handle soft fail #1276
Conversation
5cb07e1
to
437ce42
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 90 91 +1
Lines 5393 5403 +10
=======================================
+ Hits 5316 5326 +10
Misses 77 77
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,please test it on our deployments just to rule out any regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add test cases to soft_fail
?
Added some unit tests |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
closes: #1170
Handle soft_fail param for sensor
TODO