Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle soft fail #1276

Merged
merged 16 commits into from
Aug 7, 2023
Merged

Handle soft fail #1276

merged 16 commits into from
Aug 7, 2023

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Aug 2, 2023

closes: #1170
Handle soft_fail param for sensor

TODO

  • run test on astro

@pankajastro pankajastro force-pushed the soft_fail branch 3 times, most recently from 5cb07e1 to 437ce42 Compare August 2, 2023 15:56
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (83957b8) 98.57% compared to head (a95e91a) 98.57%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1276   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          90       91    +1     
  Lines        5393     5403   +10     
=======================================
+ Hits         5316     5326   +10     
  Misses         77       77           
Files Changed Coverage Δ
astronomer/providers/amazon/aws/sensors/batch.py 100.00% <100.00%> (ø)
astronomer/providers/amazon/aws/sensors/emr.py 100.00% <100.00%> (ø)
...r/providers/amazon/aws/sensors/redshift_cluster.py 92.59% <100.00%> (-7.41%) ⬇️
astronomer/providers/amazon/aws/sensors/s3.py 100.00% <100.00%> (ø)
...er/providers/apache/hive/sensors/hive_partition.py 100.00% <100.00%> (ø)
astronomer/providers/core/sensors/external_task.py 95.83% <100.00%> (+0.08%) ⬆️
astronomer/providers/dbt/cloud/sensors/dbt.py 100.00% <100.00%> (ø)
...ronomer/providers/google/cloud/sensors/bigquery.py 100.00% <100.00%> (ø)
astronomer/providers/google/cloud/sensors/gcs.py 94.80% <100.00%> (+2.49%) ⬆️
astronomer/providers/http/sensors/http.py 85.71% <100.00%> (+0.52%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,please test it on our deployments just to rule out any regression

Copy link
Contributor

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add test cases to soft_fail?

astronomer/providers/apache/hive/sensors/hive_partition.py Outdated Show resolved Hide resolved
astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
astronomer/providers/sftp/sensors/sftp.py Show resolved Hide resolved
astronomer/providers/snowflake/sensors/snowflake.py Outdated Show resolved Hide resolved
astronomer/providers/snowflake/sensors/snowflake.py Outdated Show resolved Hide resolved
astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
@pankajastro
Copy link
Contributor Author

Should we add test cases to soft_fail?

Added some unit tests

astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
astronomer/providers/utils/sensor_util.py Outdated Show resolved Hide resolved
@pankajastro pankajastro merged commit ff09c1f into main Aug 7, 2023
2 checks passed
@pankajastro pankajastro deleted the soft_fail branch August 7, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle soft fail for sensors
3 participants