-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Aio refreshable creds for assume role #1304
Conversation
9809435
to
d2c30fa
Compare
will work next on tests |
Cc: @abhishekbhakat |
d2c30fa
to
242d023
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 98.57% 98.58%
=======================================
Files 91 91
Lines 5404 5429 +25
=======================================
+ Hits 5327 5352 +25
Misses 77 77
☔ View full report in Codecov by Sentry. |
68f1ba1
to
cfe1852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- we should test the existing aws integration test on Astro once
- what do you think about adding an integration test or using some existing one to use this method of authentication?
|
22b7f5d
to
ada2cbb
Compare
@abhishekbhakat would you like to test this PR? |
Currently, for assume_role method, the hook gets a one time credentials
and when they expire the sensor fails. Thus, we leverage refreshable
credentials to support the sensor and not fail when using assume_role
method with the role_arn type connections.
closes: #1292