Fix Dataproc dag failure due to new RC 8.4.0rc1 #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajaths010494
changed the title
rajaths010494
changed the title
pankajkoti
reviewed
Sep 29, 2022
pankajkoti
reviewed
Sep 29, 2022
rajaths010494
changed the title
pankajkoti
approved these changes
Sep 29, 2022
rajaths010494
requested review from
phanikumv,
bharanidharan14 and
pankajastro
as code owners
Codecov ReportBase: 98.38% // Head: 98.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 84 84
Lines 4339 4343 +4
=======================================
+ Hits 4269 4273 +4
Misses 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rajaths010494
commented
Sep 29, 2022
kaxil
reviewed
Sep 29, 2022
kaxil
reviewed
Sep 29, 2022
…astronomer-providers into fix-datprocdag-newRC
kaxil
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
get_credentialsfunctions in the GoogleBaseHook are made public methods with PR 25785.. So example dataproc was looking for_get_credentialswhich was renamed toget_credentialsAlso fixed mypy hints caused due to RC 8.4.0rc1
closes #675