Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(setup.cfg): pinning snowflake-sqlalchemy to greater than or eqaul to 1.4.4 #962

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Apr 17, 2023

As discussed in #958, we might need to pin snowflake-sqlalchemy >= 1.4.4 to resolved the issue. For the next step, I'm thinking of sending a PR to pin it to >= 1.4.4 on apache-airflow-providers-snowflake and then pin the apache-airflow-providers-snowflake in this repo after it's released

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (272e63a) 98.62% compared to head (4d3f3f4) 98.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          90       90           
  Lines        5017     5017           
=======================================
  Hits         4948     4948           
  Misses         69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a minor comment if you could address before merging, please.

setup.cfg Outdated Show resolved Hide resolved
@Lee-W Lee-W merged commit 9048938 into main Apr 17, 2023
@Lee-W Lee-W deleted the issue-958 branch April 17, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants