Multi-topic publishing #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing a single Producer object to be used to write to multiple topics.
Append the name of the target topic to error messages when it may be relevant. This latter feature uses a hard-coded list of error codes, which is not ideal, but seems tolerable, as this only affects the exception error message, is never technically wrong (since the error arose from a message being sent to the referenced topic), the full information is always available though the `error` and `message` subobjects, and the set of relevant errors changes infrequently.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes setting a single topic for a
Producerobject optional, and enables the target topic to be specified whenwrite()is called, so that oneProducercan publish to multiple topics. Users who want the convenience of not having to specify the topic for each message when sending to only a single topic can use the interface unchanged, but this enables much improved efficiency for users who need to publish to multiple topics over having to create multipleProducers (with a significant overhead in background threads and file descriptors). As currently implemented, the new logic is also lenient, such that even aProducerconstructed with a specified topic will still allow the topic to be overridden on individualwrite()calls, if the user so chooses.