all: run modernize (#43)

Author: astrophena

web/internal/hashfs/hashfs_test.go

@@ -184,7 +184,7 @@ func TestFileServer(t *testing.T) {
 		h := hashfs.FileServer(fsys)
 		hash := "\"b633a587c652d02386c4f16f8c6f6aab7352d97f16367c3c40576214372dd628\""
 
-		for i := 0; i < 2; i++ {
+		for range 2 {
 			w := httptest.NewRecorder()
 			h.ServeHTTP(w, r)
 

web/respond.go

@@ -81,10 +81,10 @@ func respondJSON(w http.ResponseWriter, response any, wroteStatus bool) {
 		if !wroteStatus {
 			w.WriteHeader(http.StatusInternalServerError)
 		}
-		w.Write([]byte(fmt.Sprintf(`{
+		w.Write(fmt.Appendf(nil, `{
   "status": "error",
   "error": "JSON marshal error: %s"
-}`, escapeForJSON(err.Error()))))
+}`, escapeForJSON(err.Error())))
 		return
 	}
 	w.Write(b)
@@ -150,7 +150,7 @@ func respondError(json bool, w http.ResponseWriter, r *http.Request, err error)
 	}
 	w.WriteHeader(int(se))
 	if se == ErrInternalServerError {
-		logf("Error %d (%s): %v", se, http.StatusText(int(se)), err)
+		logf("%s: %s %s -> %v", http.StatusText(int(se)), r.Method, r.URL.Path, err)
 	}
 	if json {
 		respondJSON(w, &errorResponse{Status: "error", Error: err.Error()}, true)
@@ -173,7 +173,7 @@ func respondError(json bool, w http.ResponseWriter, r *http.Request, err error)
 
 	var buf bytes.Buffer
 	if err := errorTemplate.Execute(&buf, data); err != nil {
-		logf("Executing error template failed: %v", err)
+		logf("web.RespondError: executing error template failed: %v", err)
 		// Fallback, if template execution fails.
 		fmt.Fprintf(w, "%d: %s", data.StatusCode, data.StatusText)
 		return

web/server_test.go

@@ -82,13 +82,11 @@ func TestServerListenAndServe(t *testing.T) {
 		Ready:      readyFunc,
 	}
 
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		if err := s.ListenAndServe(cli.WithEnv(ctx, env)); err != nil {
 			errCh <- err
 		}
-	}()
+	})
 
 	// Wait until the server is ready.
 	select {

web/tgauth/tgauth.go

@@ -203,7 +203,7 @@ func delCookie(w http.ResponseWriter, key string) {
 
 func authDataToIdentity(data string) (*Identity, error) {
 	dataMap := make(map[string]string)
-	for _, line := range strings.Split(data, "\n") {
+	for line := range strings.SplitSeq(data, "\n") {
 		parts := strings.SplitN(line, "=", 2)
 		if len(parts) == 2 {
 			dataMap[parts[0]] = parts[1]