Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition for black-body atmospheres #59

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Addition for black-body atmospheres #59

merged 3 commits into from
Jan 24, 2022

Conversation

abhimat
Copy link
Contributor

@abhimat abhimat commented Jan 12, 2022

Added new function, atmospheres.get_bb_atmosphere(), for returning black-body atmosphere. Modified test_models.test_atmosphere_model() to test the new black-body atmosphere code.

@abhimat abhimat changed the title Small addition for pure black-body atmospheres Addition for black-body atmospheres Jan 12, 2022
# Use a blackbody
bbspec = pysynphot.spectrum.BlackBody(temperature)
bbspec.convert('flam')
bbspec *= (1000 * 3.08e18 / 6.957e10)**2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about what these constants are and where they came from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt's comment... you will likely need the same inputs as the other atmosphere models (add metallicity, gravity, rebin etc... just ignore these.

@abhimat
Copy link
Contributor Author

abhimat commented Jan 20, 2022

Thanks for the suggestions! I've incorporated these changes into the latest commit

@mwhosek mwhosek merged commit b79aca7 into dev Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants