Handle trailing slash on http urls #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aarchiba 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style. There are no PEP8 style issues with this pull request - thanks! 🎉 Comment last updated at 2020-08-07 14:31:36 UTC |
pllim
reviewed
Aug 6, 2020
astropy/utils/tests/test_data.py
Outdated
| @@ -2086,3 +2086,28 @@ def test_clear_download_cache_variants(temp_cache, valid_urls): | |||
| def test_ftp_tls_auto(temp_cache): | |||
| url = "ftp://anonymous:mail%40astropy.org@gdc.cddis.eosdis.nasa.gov/pub/products/iers/finals2000A.all" | |||
| download_file(url) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('base', ["http://exmaple.com", "https://example.com"]) | |||
There was a problem hiding this comment.
Is the typo intentional?
Suggested change
| @pytest.mark.parametrize('base', ["http://exmaple.com", "https://example.com"]) | |
| @pytest.mark.parametrize('base', ["http://example.com", "https://example.com"]) |
pllim
added
Bug
Affects-dev
pllim
reviewed
Aug 6, 2020
|
p.s. Ignore coverage failure as usual. |
pllim
approved these changes
Aug 6, 2020
|
Er, not sure whether this wants a changelog entry? Otherwise fine. |
pllim
removed
the
Affects-dev
|
Doesn't hurt to have the change log if you have already written it. Thanks! |
astrofrog
pushed a commit
that referenced
this pull request
Oct 9, 2020
Handle trailing slash on http urls
eteq
pushed a commit
to eteq/astropy
that referenced
this pull request
Oct 12, 2020
Handle trailing slash on http urls
eteq
pushed a commit
that referenced
this pull request
Oct 13, 2020
Handle trailing slash on http urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to ensure the cache mechanism treats
http://example.comandhttp://example.com/equally.Fixes #10630
EDIT: Follow up of #10437