Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column string representation needs fixing for 2-d arrays with shape (n,1) #1522

Closed
astrofrog opened this issue Oct 3, 2013 · 8 comments · Fixed by #2104
Closed

Column string representation needs fixing for 2-d arrays with shape (n,1) #1522

astrofrog opened this issue Oct 3, 2013 · 8 comments · Fixed by #2104

Comments

@astrofrog
Copy link
Member

The following example demonstrates the issue:

In [5]: print(Column([(1,),(2,),(3,)], 'a'))
a [1] 
------
1 .. 1
2 .. 2
3 .. 3

In this case, I think it should only show each value once.

I think this, once fixed, can be backported to 0.2.5?

@embray
Copy link
Member

embray commented Oct 24, 2013

In the interest of still releasing an 0.2.5 around the time of (if not a bit before) 0.3, I'm going to defer this issue for now to 0.2.6 (all of whose issues may be moved to 0.3.1 or whatever).

@astrofrog
Copy link
Member Author

Sounds good!

@astrofrog
Copy link
Member Author

FYI I'm going to have a student work on this issue to practice contributing.

@taldcroft
Copy link
Member

👍

@astrofrog
Copy link
Member Author

@luzuku - for information, here is the official page for the issue that we discussed last Friday.

@kaichogami
Copy link
Contributor

@astrofrog I am sorry if I might rude towards your student, but can I work to fix this issue as well?

@astrofrog
Copy link
Member Author

@kaichogami - this is already fixed locally and my student will be opening the pull request soon.

@kaichogami
Copy link
Contributor

I see. Thank you for replying immediately! :)

taldcroft added a commit that referenced this issue Feb 19, 2014
Printing columns with shape (n,1,…,1). Fixes #1522
taldcroft added a commit that referenced this issue Feb 25, 2014
Printing columns with shape (n,1,…,1). Fixes #1522
ktchrn pushed a commit to ktchrn/astropy that referenced this issue Oct 28, 2014
ktchrn pushed a commit to ktchrn/astropy that referenced this issue Oct 28, 2014
ktchrn pushed a commit to ktchrn/astropy that referenced this issue Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants