Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cextern/erfa to 1.1.0 #2497

Merged
merged 3 commits into from
May 16, 2014
Merged

update cextern/erfa to 1.1.0 #2497

merged 3 commits into from
May 16, 2014

Conversation

eteq
Copy link
Member

@eteq eteq commented May 15, 2014

This updates the copy of ERFA to the just-released v1.1.0

This closes #1031 because it was fixed in the latest SOFA release.

@eteq eteq added this to the v0.4.0 milestone May 15, 2014
@eteq eteq added the time label May 15, 2014
@astrofrog
Copy link
Member

Should astropy include a regression test for #1031?

cc @taldcroft

[ci skip]
@eteq
Copy link
Member Author

eteq commented May 15, 2014

Oh, that's a good idea - @taldcroft, feel free to either PR against my branch of this to add said test, or as a separate PR after this is merged.

@taldcroft
Copy link
Member

Let's just go ahead and merge this and I'll write the regression test for #1031 after that.

@taldcroft
Copy link
Member

Why aren't there any Travis results or tests pending? I would like to see that before merge!

@astrofrog
Copy link
Member

Not sure why it didn't test the latest commit, but 41fc760
/ https://travis-ci.org/astropy/astropy/builds/25280521 passed, so good to go?

@eteq
Copy link
Member Author

eteq commented May 16, 2014

@taldcroft @astrofrog - There's no travis result shown on the merge button because 433f006 is the latest commit, and it has [ci skip] in the commit log (it's only the changelog entry and I didn't want to block up travis). But apparently that hides the merge status. As @astrofrog said, though, 41fc760 passed without problems, so I'll go ahead and merge this.

eteq added a commit that referenced this pull request May 16, 2014
update cextern/erfa to 1.1.0
@eteq eteq merged commit 9db8911 into astropy:master May 16, 2014
@eteq eteq deleted the erfa-to-1.1.0 branch May 16, 2014 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTC <=> TAI does not round trip for dates 1960 to 1972
4 participants