Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few short docstrings in examples for issue #1414 #2728

Merged
merged 1 commit into from
Jul 16, 2014
Merged

A few short docstrings in examples for issue #1414 #2728

merged 1 commit into from
Jul 16, 2014

Conversation

jehturner
Copy link
Member

In the spirit of encouraging docstrings in tests...

See #1414

In the spirit of encouraging docstrings in tests...
@jehturner jehturner mentioned this pull request Jul 11, 2014
@mhvk
Copy link
Contributor

mhvk commented Jul 11, 2014

👍

1 similar comment
@embray
Copy link
Member

embray commented Jul 11, 2014

👍

@astrofrog astrofrog added this to the v0.4.1 milestone Jul 13, 2014
@astrofrog
Copy link
Member

@jehturner - thanks! Let's merge it in to 0.4.1 once 0.4 is out.

astrofrog added a commit that referenced this pull request Jul 16, 2014
A few short docstrings in examples for issue #1414
@astrofrog astrofrog merged commit 03ade63 into astropy:master Jul 16, 2014
@astrofrog
Copy link
Member

@embray - for this and #2742 it doesn't really make sense to have a changelog entry, but how do you want to track the fact that these can be backported? Should we add a changelog entry 'miscellaneous improvements to docs and docstrings [#2742, #2728]'?

@astrofrog
Copy link
Member

Oh I guess you just use the milestones, right?

@embray
Copy link
Member

embray commented Jul 16, 2014

Yeah, the milestone is fine. Sometimes I do add a changelog entry for misc doc improvements just as you suggested so that credit can be given where credit is due. It's not generally as important though.

astrofrog added a commit that referenced this pull request Aug 6, 2014
A few short docstrings in examples for issue #1414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants