-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reading HTML tables with unicode values #5410
Conversation
Test reading a table with unicode values | ||
""" | ||
# If we don't have unicode literals then return | ||
if isinstance('', bytes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid this and using TEST_UNICODE_LITERALS
, the strings below could simply be defined with the u'...'
syntax, or maybe I miss something ?
5a3dec5
to
3c9f99d
Compare
@saimn - good point. During development I did try using unicode strings at one point and this failed, but this might have been when there were other problems. I tried just and it worked as expected, so this is definitely cleaner. New rebased version pushed. |
Should this be a bug fix? Also, I noticed this overrides |
@mhvk - reading unicode in Python 2.7 is not supported per the following Note in the docs:
So this is really not a bug because reading unicode is explicitly not supported. But of course we could be more liberal about the definition of a bug. |
And as a reminder, unicode is not supported for Python 2.7 because all the other Python readers use the stdlib |
@taldcroft - OK, makes sense. I agree that we should not put effort in making this work on python2 |
3c9f99d
to
b507675
Compare
Fixes #5409.