Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a mirror for the astropy data repository #5547

Merged
merged 2 commits into from
May 9, 2017

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Dec 2, 2016

In view of the STScI server being down this weekend, this seems like a good time to add a config item for a mirror for data.astropy.org :) While doing this, I realized that in the remote-data plugin, I need to actually read the URLs from the astropy.utils.data config not hard-code URLs....

@astrofrog
Copy link
Member Author

I'll finish this up tomorrow morning. I need to figure out whether the dataurl config item can be changed to a list at this point (or if config items even support list inputs)

@eteq
Copy link
Member

eteq commented Dec 3, 2016

@astrofrog - if you look at vo/validator/__init__.p y you'll see an example of a list config item (for the same purpose, actually!)

Also, I'm realizing a downside of this: the caching machinery will double-cache these files because they have different URLs :( I don't think there's an easy fix for that, although a long-term solution might be too add a mirror option to the caching stuff. (It would treat the main URL as the cache name, but the mirror as the download location if not cached)

@bsipocz bsipocz added this to the v2.0.0 milestone Mar 23, 2017
@bsipocz
Copy link
Member

bsipocz commented Mar 23, 2017

@astrofrog - Would be nice to have this in the next release. Could you rebase to get the changelog moved to 2.0?

@pllim
Copy link
Member

pllim commented May 9, 2017

@bsipocz , I moved the change log for as requested.

@eteq , as for making the config item from a string to a list, it would require some aliasing and deprecation warning, which is more work. I think we can re-consider that if we have more than one mirrors. Otherwise, this looks sufficient for now (despite some code duplication).

@bsipocz bsipocz merged commit 090e654 into astropy:master May 9, 2017
@bsipocz
Copy link
Member

bsipocz commented May 9, 2017

Thanks @pllim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants