Added new functions to unregister readers, writers, and identifiers #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jun 15, 2017
CHANGES.rst
Outdated
| @@ -56,6 +56,8 @@ New Features | |||
|
|
|||
| - ``astropy.io.registry`` | |||
|
|
|||
| - New functions to unregister readers, writers, and identifiers. [#6216] | |||
There was a problem hiding this comment.
Off by one!
Do we need What's New for this?
There was a problem hiding this comment.
Oops: astropy/astropy-tools@127fffc 😊
Don't think we need a what's new, I don't think this is really exciting enough to qualify.
6 tasks
eteq
approved these changes
Jun 16, 2017
astropy/io/registry.py
Outdated
| _identifiers.pop((data_format, data_class)) | ||
| else: | ||
| raise IORegistryError("No identifier defined for format '{0}' and class '{1}'" | ||
| ''.format(data_format, data_class.__name__)) |
There was a problem hiding this comment.
I'll just fix this directly and merge.
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@taldcroft @MSeifert04 - I think you contributed the most edits to this file, so tagging you so you can review this. I'd like to get this in 2.0 if it's uncontroversial.