Deprecate imshow_only_kwargs keyword in imshow_norm #9915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrybradley
added
visualization
API change
larrybradley
changed the title
imshow_only_kwargs keyword in imshow_norm
pllim
reviewed
Jan 31, 2020
| @@ -238,15 +238,6 @@ def test_imshow_norm(): | |||
|
|
|||
| imshow_norm(image, ax=ax, vmin=0, vmax=1) | |||
|
|
|||
| # Note that the following is deprecated in Matplotlib 3.2 | |||
There was a problem hiding this comment.
I think we should keep the tests until the keyword is actually removed. Although we should add a pytest.warns to ensure the deprecation warning is raised correctly too.
There was a problem hiding this comment.
Ah yes, thanks! Done.
|
Note to maintainer: After this is merged, please open an issue to remind ourselves to remove the keyword after a deprecation period. |
larrybradley
force-pushed
the
imshow_norm-deps
branch
from
3c04758
to
4466725
Compare
larrybradley
force-pushed
the
imshow_norm-deps
branch
from
4466725
to
77b52db
Compare
Cadair
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9861.
Note that I didn't use
deprecated_renamed_argumentbecause of the bug I discovered in #9914.