Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Make ignore_matplotlibrc a pytest fixture #10046

Merged
merged 1 commit into from
Mar 19, 2020
Merged

TST: Make ignore_matplotlibrc a pytest fixture #10046

merged 1 commit into from
Mar 19, 2020

Conversation

lpsinger
Copy link
Contributor

This allows it to be composed with pytest marks (e.g. pytest.mark.skipif). See #9991.

@pllim pllim requested a review from astrofrog March 17, 2020 15:44
@pllim pllim added the testing label Mar 17, 2020
@pllim pllim requested a review from Cadair March 17, 2020 15:45
@pllim pllim added this to the v4.0.1 milestone Mar 17, 2020
@pllim pllim added the Bug label Mar 17, 2020
bsipocz
bsipocz approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all OK to me, but will we better wait with merging for the fix for the pytest issue, to retrigger CI.

Cadair
Cadair approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pllim pllim added the 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Mar 18, 2020
@lpsinger @bsipocz
TST: Make ignore_matplotlibrc a pytest fixture
57a4bf6 
This allows it to be composed with pytest marks (e.g.
`pytest.mark.skipif`). See astropy#9991.
@bsipocz bsipocz force-pushed the ignore-matplotlibrc-fixture branch from 72c28ae to 57a4bf6 Compare March 19, 2020 16:56
@bsipocz bsipocz merged commit 0c5ea27 into astropy:master Mar 19, 2020
@bsipocz
Copy link
Member

bsipocz commented Mar 19, 2020

Thanks @lpsinger!

@lpsinger lpsinger deleted the ignore-matplotlibrc-fixture branch March 19, 2020 18:36
bsipocz added a commit that referenced this pull request Mar 22, 2020
@bsipocz
Merge pull request #10046 from lpsinger/ignore-matplotlibrc-fixture
3cfb769 
TST: Make ignore_matplotlibrc a pytest fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

@bsipocz bsipocz bsipocz approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees
No one assigned
Labels
Bug no-changelog-entry-needed testing visualization.wcsaxes visualization 💤 merge-when-ci-passes Do not use: We have auto-merge option now.
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lpsinger @bsipocz @Cadair @pllim