Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of deprecated unicode APIs. #10493

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Remove use of deprecated unicode APIs. #10493

merged 5 commits into from
Jun 17, 2020

Conversation

methane
Copy link
Contributor

@methane methane commented Jun 15, 2020

Description

This pull request replaces deprecated unicode APIs using Py_UNICODE with UTF-8 APIs.

Fixes #10490

@pllim
Copy link
Member

pllim commented Jun 15, 2020

There is a segfault. pytest-faulthandler might help smoke it out (or might not), but looks like you might need to debug this locally. Hopefully the testing guidelines would help.

@pllim pllim added this to the v4.2 milestone Jun 15, 2020
@pllim
Copy link
Member

pllim commented Jun 16, 2020

Tests passed now. Thank you very much! Someone will review this. In the meantime, please be patient.

pllim
pllim approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We appreciate your help in applying PEP 393 recommendations here and the clean-up of function to escape XML.

@pllim pllim merged commit bf5fa75 into astropy:master Jun 17, 2020
@pllim pllim mentioned this pull request Jun 17, 2020
Closed
@methane methane deleted the pep393 branch June 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
io.votable no-changelog-entry-needed Refactoring utils
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

Please remove PEP 393 deprecated APIs.
2 participants
@methane @pllim