Powerlaw model #1184
Merged
Powerlaw model #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old commits: * fix models reference in test and use super to init * needed to add powerlaw to __all__ * need to use parameters.Parameter * power law model only takes 2 pars * tests still fail, but the error no longer makes any sense * fixed the tests. Sigh. * skip test if no scipy * use the derivative! * corrected deriv function (was correct at some time earlier; must have forgotten to pull...)
|
Changes look good to me. I closed #1048 in favor of this. |
|
One of the builds failed for reasons unrelated to the changes. Should Travis be restarted and if so how? |
|
@nden - the best way to get them restarted is to use Anyway, I restarted it now - as you surmised I think it wasn't any sort of real error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to finalize PowerlawModel