Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Relax pyerfa pin for oldestdeps, skip URL in linkcheck (v5.0.x only) #14567

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Mar 23, 2023

Description

This pull request is to relax the pyerfa pin added in #14562 because pyerfa 2.0.0.3 is now released that reverted their numpy minversion change. This PR also excludes ui.adsabs.harvard.edu from linkcheck because I think they blocking our CI.

This patch is directly for v5.0.x. Separate PR will be made for main and v5.2.x (those were not affected by pyerfa 2.0.0.2 release).

and exclude ui.adsabs.harvard.edu from linkcheck because I think they blocking CI.

This patch is directly for v5.0.x. Separate PR will be made for main and v5.2.x.
@pllim pllim added no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports Extra CI Run cron CI as part of PR labels Mar 23, 2023
@pllim pllim added this to the v5.0.6 milestone Mar 23, 2023
@pllim
Copy link
Member Author

pllim commented Mar 23, 2023

"When Opened" failure appears unrelated (server error).

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pllim
Copy link
Member Author

pllim commented Mar 23, 2023

32-bit job works again! 🤯

@pllim pllim merged commit 8068491 into astropy:v5.0.x Mar 23, 2023
@pllim pllim deleted the unpin-pyerfa-2.0.0.1-on-v5.0.x branch March 23, 2023 16:31
@mhvk
Copy link
Contributor

mhvk commented Mar 23, 2023

Bizarre, but we'll take it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Extra CI Run cron CI as part of PR no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants