-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: adjustments to np.trapz->np.trapezoid renaming #15986
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
f0ea179
to
6fb74b5
Compare
I missed test for masked quantities. I'll come back to this later today. |
8040b7d
to
027a096
Compare
027a096
to
607b2f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good solution with the check_trapezoid
name.
This comment was marked as resolved.
This comment was marked as resolved.
I'll take care of the manual bp |
TST: adjustments to np.trapz->np.trapezoid renaming (cherry picked from commit 6185442)
Backport PR #15986 on branch v6.0.x (TST: adjustments to np.trapz->np.trapezoid renaming)
Actually I think I didn't need to keep the warning filter, as the deprecation was not released yet. I'll clean it up in a follow up PR. |
Ah, good point! That we did just because they had earlier decided to deprecate... |
Description
This fixes new instabilities seen in devdeps CI (for instance https://github.com/astropy/astropy/actions/runs/7771887655/job/21193705886?pr=15985)
xref numpy/numpy#25738